Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove aiprops report #302

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Remove aiprops report #302

wants to merge 2 commits into from

Conversation

jeanconn
Copy link
Contributor

@jeanconn jeanconn commented Sep 23, 2024 •
edited
Loading

Description

Remove aiprops report.

This removes the generation of a table html page of the AIPROPS entries for science observations. We weren't using this anyway and removing it here removes another sybase dependence from our tools.

This PR also includes an unrelated bug fix noticed when writing out reports - the template included the slew error that we no longer have in starcheck, and just removing it from the template seems fine.

This removes a dependence on the old sybase-based aiprops table.

Interface impacts

Removes a small html file of the aiprops data.

Testing

Unit tests

  • Linux
jeanconn-fido> git rev-parse HEAD
270bf6df5a8a1c3088543fd27c50889a2d616a92
(ska3-masters) jeanconn-fido> pytest
================================================= test session starts ==================================================
platform linux -- Python 3.11.8, pytest-7.4.4, pluggy-1.4.0
rootdir: /proj/sot/ska/jeanproj/git
configfile: pytest.ini
plugins: timeout-2.2.0, anyio-4.3.0
collected 108 items                                                                                                    

mica/archive/tests/test_aca_dark_cal.py ..................                                                       [ 16%]
mica/archive/tests/test_aca_hdr3.py .                                                                            [ 17%]
mica/archive/tests/test_aca_l0.py ...                                                                            [ 20%]
mica/archive/tests/test_asp_l1.py .......                                                                        [ 26%]
mica/archive/tests/test_cda.py ..............................................                                    [ 69%]
mica/archive/tests/test_obspar.py .                                                                              [ 70%]
mica/report/tests/test_write_report.py .                                                                         [ 71%]
mica/starcheck/tests/test_catalog_fetches.py ...............                                                     [ 85%]
mica/stats/tests/test_acq_stats.py ...                                                                           [ 87%]
mica/stats/tests/test_guide_stats.py ....                                                                        [ 91%]
mica/vv/tests/test_vv.py .........                                                                               [100%]

=========================================== 108 passed in 551.30s (0:09:11

Independent check of unit tests by [REVIEWER NAME]

  • [PLATFORM]:

Functional tests

The test_write_report has a functional test to confirm that a report for a few obsids can be written without error, but it does not keep the output. I used that test setup to make a report for a few obsids:

In [1]: from mica.report import report

In [2]: report.REPORT_SERVER = '/proj/sot/ska/www/ASPECT_ICXC/test_review_outputs/mica/pr-302/report.db3'

In [3]: report.REPORT_ROOT = '/proj/sot/ska/www/ASPECT_ICXC/test_review_outputs/mica/pr-302'

In [4]: report.main(28790)
Making report for 28790
Writing out full report to /proj/sot/ska/www/ASPECT_ICXC/test_review_outputs/mica/pr-302/28/28790/index.html

In [6]: report.main(44001)
Making report for 44001
Processing ER; no V&V available
Writing out full report to /proj/sot/ska/www/ASPECT_ICXC/test_review_outputs/mica/pr-302/44/44001/index.html

In [7]: report.main(16000)
Making report for 16000
Writing out full report to /proj/sot/ska/www/ASPECT_ICXC/test_review_outputs/mica/pr-302/16/16000/index.html

https://icxc.cfa.harvard.edu/aspect/test_review_outputs/mica/pr-302/16/16000/
https://icxc.cfa.harvard.edu/aspect/test_review_outputs/mica/pr-302/28/28790/
https://icxc.cfa.harvard.edu/aspect/test_review_outputs/mica/pr-302/44/44001/

Base automatically changed from ruff to master September 26, 2024 22:32
@jeanconn jeanconn marked this pull request as ready for review September 27, 2024 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@javierggt javierggt Awaiting requested review from javierggt

@taldcroft taldcroft Awaiting requested review from taldcroft

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jeanconn